-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add WhiteSpace setter and getter methods #11919
Conversation
Personally, I don't really see the need of this addition; it bloats the |
3de8689
to
fcbecec
Compare
If it behaves like this, then maybe better to not add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with the white-space
CSS properties that much, but the new API look good to me.
Added Leif as he was the author of this enhancement. |
The implementation seems to be in line with what I have expected. My only remark is that there's some new API in the enum that is implicitly public that doesn't have javadocs, but that's up to the team do decide what policy you have for such cases. |
SonarQube analysis reported 1 issue
|
fixes #4577
Description
Please list all relevant dependencies in this section and provide summary of the change, motivation and context.
Fixes # (issue)
Type of change
Checklist
Additional for
Feature
type of change