Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Only write package.json if something actually changed #11848

Merged
merged 1 commit into from
Sep 14, 2021
Merged

fix: Only write package.json if something actually changed #11848

merged 1 commit into from
Sep 14, 2021

Conversation

caalador
Copy link
Contributor

Description

Flag update of vaadin version as an addition
also and only write the package.json if
thee was an actual change in content.

Fixes #11259

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@caalador
fix: Only write package.json if something actually changed
c08335a 
Flag update of vaadin version as an addition
also and only write the package.json if
thee was an actual change in content.

Fixes #11259
@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 1 issue

  1. CRITICAL NodeUpdater.java#L255: Either log or rethrow this exception. rule

@denis-anisimov denis-anisimov merged commit abb20b5 into 2.7 Sep 14, 2021
@denis-anisimov denis-anisimov deleted the issues/11259_only_write_for_change_2.x branch September 14, 2021 12:31
vaadin-bot pushed a commit that referenced this pull request Sep 14, 2021
@caalador @vaadin-bot
fix: Only write package.json if something actually changed (#11848)
740fe90 
Flag update of vaadin version as an addition
also and only write the package.json if
thee was an actual change in content.

Fixes #11259
vaadin-bot added a commit that referenced this pull request Sep 14, 2021
@vaadin-bot @caalador
fix: Only write package.json if something actually changed (#11848) (#…
1a033ff 
…11851)

Flag update of vaadin version as an addition
also and only write the package.json if
thee was an actual change in content.

Fixes #11259

Co-authored-by: caalador <[email protected]>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 14.7.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-anisimov denis-anisimov denis-anisimov approved these changes

Assignees
No one assigned
Labels
Released with Platform 14.7.1 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caalador @vaadin-bot @denis-anisimov