Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add equals and hashCode to SimpleResult (#11827) (CP: 2.7) #11840

Merged
merged 1 commit into from
Sep 14, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -110,4 +110,25 @@ public <X extends Throwable> R getOrThrow(
}
}

@Override
public boolean equals(Object obj) {
if (obj == this) {
return true;
}
if (obj == null) {
return false;
}
if (!obj.getClass().equals(getClass())) {
return false;
}
SimpleResult<?> that = (SimpleResult<?>) obj;
return Objects.equals(that.value, value)
&& Objects.equals(that.message, message);
}

@Override
public int hashCode() {
return Objects.hash(value, message);
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
/*
* Copyright 2000-2021 Vaadin Ltd.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not
* use this file except in compliance with the License. You may obtain a copy of
* the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations under
* the License.
*/
package com.vaadin.flow.data.binder;

import org.junit.Assert;
import org.junit.Test;

public class SimpleResultTest {

@Test
public void twoEqualSimpleResults_objectsAreEqual() {
SimpleResult<String> one = new SimpleResult<String>("foo", null);
SimpleResult<String> two = new SimpleResult<String>("foo", null);
Assert.assertEquals(one, two);
}

@Test
public void differentValues_objectsAreUnequal() {
SimpleResult<String> one = new SimpleResult<String>("foo", null);
SimpleResult<String> two = new SimpleResult<String>("baz", null);
Assert.assertNotEquals(one, two);
}

@Test
public void differentMessages_objectsAreUnequal() {
SimpleResult<String> one = new SimpleResult<String>(null, "bar");
SimpleResult<String> two = new SimpleResult<String>(null, "baz");
Assert.assertNotEquals(one, two);
}

@Test
public void differentClasses_objectsAreUnequal() {
SimpleResult<String> one = new SimpleResult<String>("foo", null);
SimpleResult<String> two = new SimpleResult<String>("foo", null) {
};
Assert.assertNotEquals(one, two);
}

@Test
public void nullIsNotEqualToObject() {
SimpleResult<String> one = new SimpleResult<String>("foo", null);
Assert.assertNotEquals(one, null);
}

@Test
public void twoEqualSimpleResults_hashCodeIsTheSame() {
SimpleResult<String> one = new SimpleResult<String>("foo", null);
SimpleResult<String> two = new SimpleResult<String>("foo", null);
Assert.assertEquals(one.hashCode(), two.hashCode());
}
}