Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add target enums for Anchor (#8346) (#8397) #10940

Merged
merged 1 commit into from
May 10, 2021
Merged

feat: Add target enums for Anchor (#8346) (#8397) #10940

merged 1 commit into from
May 10, 2021

Conversation

pleku
Copy link
Contributor

@pleku pleku commented May 7, 2021

Cherry-picks #8397

Fixes #8346

Co-authored-by: Denis Anisimov [email protected]

@pleku pleku requested a review from denis-anisimov May 7, 2021 07:38
@pleku pleku mentioned this pull request May 7, 2021
Merged
@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 5 issues

  1. MAJOR Anchor.java#L84: Remove this call from a constructor to the overridable "setHref" method. rule
  2. MAJOR Anchor.java#L85: Remove this call from a constructor to the overridable "setText" method. rule
  3. MAJOR Anchor.java#L86: Remove this call from a constructor to the overridable "setTarget" method. rule
  4. MAJOR AnchorTargetValue.java#L57: Reduce this anonymous class number of lines from 23 to at most 20, or make it a named class. rule
  5. MINOR AnchorTargetValue.java#L50: "public" is redundant in this context. rule

@denis-anisimov denis-anisimov merged commit 533c8a9 into 2.7 May 10, 2021
@denis-anisimov denis-anisimov deleted the cp/8397 branch May 10, 2021 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-anisimov denis-anisimov denis-anisimov approved these changes

Assignees
No one assigned
Labels
+1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pleku @vaadin-bot @denis-anisimov @jhult