fix: store spring csrf to bootstrap page #10577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/github.com/vaadin/flow into haijian/store-spring-csrf-to-bootstrap-page
…g-csrf-to-bootstrap-page
joheriks
suggested changes
Apr 8, 2021
flow-server/src/main/java/com/vaadin/flow/server/communication/IndexHtmlRequestHandler.java
Outdated
Show resolved
Hide resolved
joheriks
reviewed
Apr 8, 2021
flow-client/src/main/resources/META-INF/resources/frontend/Authentication.ts
Outdated
Show resolved
Hide resolved
fluorumlabs
suggested changes
Apr 8, 2021
flow-client/src/main/resources/META-INF/resources/frontend/Authentication.ts
Outdated
Show resolved
Hide resolved
flow-client/src/main/resources/META-INF/resources/frontend/Authentication.ts
Outdated
Show resolved
Hide resolved
flow-client/src/main/resources/META-INF/resources/frontend/Authentication.ts
Outdated
Show resolved
Hide resolved
platosha
requested changes
Apr 8, 2021
flow-client/src/main/resources/META-INF/resources/frontend/Authentication.ts
Outdated
Show resolved
Hide resolved
…g-csrf-to-bootstrap-page
haijian-vaadin
force-pushed
the
haijian/store-spring-csrf-to-bootstrap-page
branch
from
f71a0a3
to
b864780
Compare
Closed
fluorumlabs
previously approved these changes
Apr 8, 2021
platosha
approved these changes
Apr 9, 2021
joheriks
approved these changes
Apr 9, 2021
haijian-vaadin
added a commit
that referenced
this pull request
Apr 9, 2021
Stores spring CSRF token into meta tags into the bootstrap page, which is used for `login()` and `logout()` helpers. It has the benefit that login and logout are now Spring CSRF protected, we no longer need to ingore Spring CSRF protection for login like `http.csrf().ignoringAntMatchers("/login");`
Merged
haijian-vaadin
added a commit
that referenced
this pull request
Apr 9, 2021
Stores spring CSRF token into meta tags into the bootstrap page, which is used for `login()` and `logout()` helpers. It has the benefit that login and logout are now Spring CSRF protected, we no longer need to ingore Spring CSRF protection for login like `http.csrf().ignoringAntMatchers("/login");`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stores spring CSRF token into meta tags into the bootstrap page, which is used for
login()andlogout()helpers. It has the benefit that login and logout are now Spring CSRF protected, we no longer need to ingore Spring CSRF protection for login likehttp.csrf().ignoringAntMatchers("/login");