Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable DialogShortcutIT flaky tests #10496

Merged
merged 1 commit into from
Mar 30, 2021
Merged

chore: disable DialogShortcutIT flaky tests #10496

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions flow-tests/test-root-context/src/test/java/com/vaadin/flow/uitest/ui/DialogShortcutIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import com.vaadin.testbench.TestBenchElement;
import org.junit.Assert;
import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test;
import org.openqa.selenium.By;
import org.openqa.selenium.WebElement;
Expand Down Expand Up @@ -76,6 +77,7 @@ public void dialogOpenedWithShortcutNoListenOn_sameShortcutListeningOnUi_bothExe
validateLatestShortcutEvent(4, DialogShortcutView.UI_BUTTON);
}

@Ignore("Flaky test, see https://github.com/vaadin/flow/issues/10481")
@Test
public void dialogOpenedWithListenOnShortcut_dialogReopened_oldShortcutStillWorks() {
openReusedDialog();
Expand Down Expand Up @@ -103,6 +105,7 @@ public void dialogOpenedWithListenOnShortcut_dialogReopened_oldShortcutStillWork
validateLatestDialogShortcut(4, REUSABLE_DIALOG_ID);
}

@Ignore("Flaky test, see https://github.com/vaadin/flow/issues/10487")
// vaadin/vaadin-dialog#229
@Test
public void twoDialogsOpenedWithSameShortcutKeyOnListenOn_dialogWithFocusExecuted() {
Expand All @@ -124,6 +127,7 @@ public void twoDialogsOpenedWithSameShortcutKeyOnListenOn_dialogWithFocusExecute
validateLatestShortcutEvent(3, DialogShortcutView.UI_BUTTON);
}

@Ignore("Flaky test, see https://github.com/vaadin/flow/issues/10491")
// #10362
@Test
public void shortcutAddedWithPreventDefault_inputFocused_enteringOtherKeysToInputWorks() {
Expand Down