-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add ignored test for long polling and @PreserveOnRefresh #10317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taefi
changed the title
fix: resolve long polling and refresh browser issue while using @PreserveOnRefresh
fix: resolve push long polling and @PreserveOnRefresh when refreshing browser
Mar 17, 2021
At the time I was working on #10103, I couldn't create a unit test to isolate the problem, so created the IT. I think if there cannot be a unit test, having this IT would be beneficial. |
taefi
changed the title
fix: resolve push long polling and @PreserveOnRefresh when refreshing browser
chore: add ignored test for long polling and @PreserveOnRefresh
May 3, 2021
mshabarov
reviewed
May 4, 2021
...-context/src/test/java/com/vaadin/flow/uitest/ui/PushLongPollingWithPreserveOnRefreshIT.java
Show resolved
Hide resolved
mshabarov
approved these changes
May 4, 2021
Artur-
pushed a commit
that referenced
this pull request
May 18, 2021
* add IT to isolate the problem * ignore until flow issue #10103 is fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.