Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ignored test for long polling and @PreserveOnRefresh #10317

Merged
merged 8 commits into from
May 4, 2021

Conversation

taefi
Copy link
Contributor

@taefi taefi commented Mar 17, 2021

No description provided.

@taefi taefi changed the title fix: resolve long polling and refresh browser issue while using @PreserveOnRefresh fix: resolve push long polling and @PreserveOnRefresh when refreshing browser Mar 17, 2021
@mshabarov
Copy link
Contributor

@taefi should these tests be added to #10582, which is going to fix the issue by upgrading the Atmosphere version?

@taefi
Copy link
Contributor Author

taefi commented Apr 9, 2021

@taefi should these tests be added to #10582, which is going to fix the issue by upgrading the Atmosphere version?

At the time I was working on #10103, I couldn't create a unit test to isolate the problem, so created the IT. I think if there cannot be a unit test, having this IT would be beneficial.

@pleku pleku requested a review from mshabarov May 3, 2021 11:27
@taefi taefi changed the title fix: resolve push long polling and @PreserveOnRefresh when refreshing browser chore: add ignored test for long polling and @PreserveOnRefresh May 3, 2021
@taefi taefi marked this pull request as ready for review May 3, 2021 13:09
@taefi taefi enabled auto-merge (squash) May 4, 2021 07:56
@taefi taefi requested a review from mshabarov May 4, 2021 11:11
@taefi taefi merged commit df4b798 into master May 4, 2021
@taefi taefi deleted the taefi/fix-flow-issue-10103 branch May 4, 2021 11:12
Artur- pushed a commit that referenced this pull request May 18, 2021
* add IT to isolate the problem

* ignore until flow issue #10103 is fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants