Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Div implement HasOrderedComponents #8188

Closed
Legioth opened this issue Apr 28, 2020 · 2 comments · Fixed by #9734
Closed

Make Div implement HasOrderedComponents #8188

Legioth opened this issue Apr 28, 2020 · 2 comments · Fixed by #9734
Labels
enhancement Good First Issue Help wanted

Comments

@Legioth
Copy link
Member

Legioth commented Apr 28, 2020

This would expose useful helpers such as getComponentAt and indexOf.
@pleku
Copy link
Contributor

pleku commented Apr 28, 2020

Should be fairly straightforward for to contribute this. Adding unit tests should be enough for testing. For new contributors, please check the guide first https://github.com/vaadin/flow/blob/master/CONTRIBUTING.md

@ghost
Copy link

ghost commented May 29, 2020

Hi @pleku. I can work on this issue after we close #3241

@knoobie knoobie mentioned this issue Jan 1, 2021
Merged
pleku pushed a commit that referenced this issue Jan 13, 2021
@knoobie
feat: add HasOrderedComponents in HTML layout elements (#9734)
46118cc 
Closes #8188

This PR implements HasOrderedComponents for all common HTML layout elements:

- Aside
- Article
- Div
- Footer
- Header
- Main
- Nav
- Section

The test is created in the base test class to simplify the unit testing of all components. To make sure that the interface isn't removed by accident, every class implements the test explicitly and fails if the interface is removed.
mshabarov pushed a commit that referenced this issue Jan 26, 2021
@knoobie @mshabarov
feat: add HasOrderedComponents in HTML layout elements (#9734)
bd35611 
Closes #8188

This PR implements HasOrderedComponents for all common HTML layout elements:

- Aside
- Article
- Div
- Footer
- Header
- Main
- Nav
- Section

The test is created in the base test class to simplify the unit testing of all components. To make sure that the interface isn't removed by accident, every class implements the test explicitly and fails if the interface is removed.

(cherry picked from commit 46118cc)
ZheSun88 pushed a commit that referenced this issue Jan 27, 2021
@knoobie @ZheSun88
feat: add HasOrderedComponents in HTML layout elements (#9734)
d56fb74 
Closes #8188

This PR implements HasOrderedComponents for all common HTML layout elements:

- Aside
- Article
- Div
- Footer
- Header
- Main
- Nav
- Section

The test is created in the base test class to simplify the unit testing of all components. To make sure that the interface isn't removed by accident, every class implements the test explicitly and fails if the interface is removed.
pleku pushed a commit that referenced this issue Jan 28, 2021
@knoobie @pleku
feat: add HasOrderedComponents in HTML layout elements (#9734)
ed34950 
Closes #8188

This PR implements HasOrderedComponents for all common HTML layout elements:

- Aside
- Article
- Div
- Footer
- Header
- Main
- Nav
- Section

The test is created in the base test class to simplify the unit testing of all components. To make sure that the interface isn't removed by accident, every class implements the test explicitly and fails if the interface is removed.

(cherry picked from commit 46118cc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Good First Issue Help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: implement HasOrderedComponents in HTML layout elements
2 participants
@Legioth @pleku