Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Material theme and release 1.1.0.alpha1 #4238

Closed
Artur- opened this issue Jun 6, 2018 · 3 comments
Closed

Add support for Material theme and release 1.1.0.alpha1 #4238

Artur- opened this issue Jun 6, 2018 · 3 comments

Comments

@Artur-
Copy link
Member

Artur- commented Jun 6, 2018

Needs a Material theme class similar to com.vaadin.flow.theme.lumo.Lumo

Probably depends on vaadin/vaadin-material-styles#49

@pleku pleku added this to the 1.1 milestone Jun 11, 2018
@pleku pleku added the theming label Jun 11, 2018
@pleku
Copy link
Contributor

pleku commented Jun 20, 2018

Acceptance Criteria

  • There is a material theme integration module in Flow
  • When the material theme has been added, we release Flow 1.1.0.alpha1 with the material theme module
  • We add documentation about material theme being available to the users in addition to Lumo

Once all the flow and all the components have been released as 1.1.0.alpha1, we add/update the dependencies to the V11 platform

@pleku pleku added the tutorial label Jun 20, 2018
@pleku pleku changed the title Support the Material theme Add support for Material theme and release 1.1.0.alpha1 Jun 20, 2018
@SomeoneToIgnore SomeoneToIgnore self-assigned this Jun 25, 2018
@SomeoneToIgnore
Copy link
Contributor

Material theme support had been added in #4322
The documentation needs to be added.

The documentation is not added, since the support is not available for testing: due to the issue described in webjars/webjars#1781 it is impossible to publish current prerelease Vaadin WebJars: we either need to wait until the issue is resolved or change the bower.json in all components with Material theme support.

@SomeoneToIgnore
Copy link
Contributor

Documentation is added in: #4238

Now the release is what's left to be done.

ZheSun88 pushed a commit to vaadin/flow-and-components-documentation that referenced this issue Jul 17, 2018
* Add doccumentation on Material theme usage

Part of vaadin/flow#4238
@gilberto-torrezan gilberto-torrezan modified the milestones: 1.1, 1.1.0.alpha1 Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants