-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Required URL/route parameter set to null when using BeforeEnterEvent.forwardTo() #20205
Labels
BFP
Bugfix priority, also known as Warranty
bug
Impact: Low
prerelease version for Vaadin 24.5.0
Released with Vaadin 23.5.8
Released with Vaadin 24.3.19
Released with Vaadin 24.4.14
Released with Vaadin 24.5.0.rc2
routing
Severity: Minor
workaround
Comments
eberleant
changed the title
URL/route parameter set to null when using BeforeEnterEvent.forwardTo()
Required URL/route parameter set to null when using BeforeEnterEvent.forwardTo()
Oct 9, 2024
mcollovati
moved this to 🔖 Normal Priority (P2)
in Vaadin Flow bugs & maintenance (Vaadin 10+)
Oct 10, 2024
tepi
moved this from 🔖 Normal Priority (P2)
to 🏗 WIP
in Vaadin Flow bugs & maintenance (Vaadin 10+)
Oct 10, 2024
github-project-automation
bot
moved this from 🏗 WIP
to ✅ Closed
in Vaadin Flow bugs & maintenance (Vaadin 10+)
Oct 10, 2024
github-project-automation
bot
moved this from 🔎Iteration reviews
to Done
in Vaadin Flow ongoing work (Vaadin 10+)
Oct 10, 2024
vaadin-bot
added a commit
that referenced
this issue
Oct 10, 2024
… parameters (#20210) (#20221) Fixes #20205 Co-authored-by: Marco Collovati <[email protected]>
vaadin-bot
added a commit
that referenced
this issue
Oct 10, 2024
… parameters (#20210) (#20220) Fixes #20205 Co-authored-by: Marco Collovati <[email protected]>
vaadin-bot
added a commit
that referenced
this issue
Oct 10, 2024
…y parameters (#20210) (CP: 24.3) (#20223) * fix: resolve route parameters when rerouting and forwardin with query parameters (#20210) Fixes #20205 * format code --------- Co-authored-by: Marco Collovati <[email protected]>
This ticket/PR has been released with Vaadin 24.5.0.rc2 and is also targeting the upcoming stable 24.5.0 version. |
This ticket/PR has been released with Vaadin 24.3.19. |
This ticket/PR has been released with Vaadin 24.4.14. |
This ticket/PR has been released with Vaadin 23.5.8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
BFP
Bugfix priority, also known as Warranty
bug
Impact: Low
prerelease version for Vaadin 24.5.0
Released with Vaadin 23.5.8
Released with Vaadin 24.3.19
Released with Vaadin 24.4.14
Released with Vaadin 24.5.0.rc2
routing
Severity: Minor
workaround
Description of the bug
In a BeforeEnterEvent, forwarding to another view with a URL/route parameter (in the path) and query parameters results in the route parameter being set to null. This happens even if the route parameter is required.
Expected behavior
The route parameter should be set to whatever is indicated by the location/path that's being forwarded to.
Minimal reproducible example
View 1:
View 2:
After going to View 1, you should be forwarded to View 2 with route parameter "foo". However, the route parameter is null. This is also reproducible using
BeforeEnterEvent.rerouteTo()
(instead offorwardTo()
).If you remove QueryParameters.empty() from the call to forwardTo(), it works as expected.
Example project: missing-url-param.zip
Versions
The text was updated successfully, but these errors were encountered: