Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some frontend source files are included in servlet context #11057

Closed
Artur- opened this issue May 21, 2021 · 5 comments · Fixed by #12128
Closed

Some frontend source files are included in servlet context #11057

Artur- opened this issue May 21, 2021 · 5 comments · Fixed by #12128
Assignees
@denis-anisimov
Labels
bug Impact: Low prerelease version for platform 22.0.0 Released with Platform 14.7.4 Released with Platform 21.0.4 Released with Platform 22.0.0.beta1 Severity: Minor webpack

Comments

@Artur-
Copy link
Member

Artur- commented May 21, 2021

Minimal reproducible example

vaadin init hellov14
cd hellov14
mvn

open http://localhost:8080/frontend/VaadinDevmodeGizmo.d.ts

Expected behavior

Could not navigate to 'frontend/VaadinDevmodeGizmo.d.ts'

Actual behavior

Shows the source from node_modules/@vaadin/flow-frontend/VaadinDevModeGizmo.d.ts

Versions:

- Vaadin / Flow version: 14.6.1
- Java version: 16
@mshabarov
Copy link
Contributor

First of all, it should be checked whether it's a Webpack who serves this static resource and is it happens only in dev mode. If so, then we propose to close this issue, because this behaviour is expected.

@denis-anisimov denis-anisimov self-assigned this Oct 18, 2021
@denis-anisimov
Copy link
Contributor

Shows the source from node_modules/@vaadin/flow-frontend/VaadinDevModeGizmo.d.ts

No.
It shows the file from flow-client JAR which is located by the path META-INF/resources/frontend/VaadinDevmodeGizmo.d.ts.

All resources inside META-INF/resources/ are available via ServletContext by the servlet spec.

denis-anisimov pushed a commit that referenced this issue Oct 25, 2021
fix: move client side frontend resources to META-INF/frontend
57b353a 
fixes #11057
@denis-anisimov denis-anisimov mentioned this issue Oct 25, 2021
Merged
9 tasks
haijian-vaadin pushed a commit that referenced this issue Oct 26, 2021
fix: move client side frontend resources to META-INF/frontend (#12128)
6356709 
* fix: move client side frontend resources to META-INF/frontend

fixes #11057

* chore: update script to put resources into /frontend and make an IT
vaadin-bot pushed a commit that referenced this issue Oct 26, 2021
@vaadin-bot
fix: move client side frontend resources to META-INF/frontend (#12128)
5a6e52b 
* fix: move client side frontend resources to META-INF/frontend

fixes #11057

* chore: update script to put resources into /frontend and make an IT
denis-anisimov pushed a commit that referenced this issue Oct 26, 2021
fix: move client side frontend resources to META-INF/frontend (#12128)
3003721 
* fix: move client side frontend resources to META-INF/frontend

fixes #11057

* chore: update script to put resources into /frontend and make an IT
@denis-anisimov denis-anisimov mentioned this issue Oct 26, 2021
Merged
9 tasks
vaadin-bot added a commit that referenced this issue Oct 26, 2021
@vaadin-bot
fix: move client side frontend resources to META-INF/frontend (#12128) (
5cc2dcb 
#12158)

* fix: move client side frontend resources to META-INF/frontend

fixes #11057

* chore: update script to put resources into /frontend and make an IT

Co-authored-by: Denis <[email protected]>
mshabarov pushed a commit that referenced this issue Oct 27, 2021
fix: move client side frontend resources to META-INF/frontend (#12128) (
19f554e 
#12161)

fixes #11057
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.beta1 and is also targeting the upcoming stable 22.0.0 version.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 14.7.4.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 21.0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denis-anisimov denis-anisimov

Labels
bug Impact: Low prerelease version for platform 22.0.0 Released with Platform 14.7.4 Released with Platform 21.0.4 Released with Platform 22.0.0.beta1 Severity: Minor webpack
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: move client side frontend resources to META-INF/frontend vaadin/flow
5 participants
@Artur- @denis-anisimov @vaadin-bot @mshabarov @miguelatvaadin