Skip to content

Commit

Permalink
fix: add equals and hashCode to SimpleResult (#11827) (#11842)
Browse files Browse the repository at this point in the history
fixes #10948

Co-authored-by: Denis <[email protected]>
  • Loading branch information
vaadin-bot and Denis authored Sep 14, 2021
1 parent 1eb62bb commit e037475
Show file tree
Hide file tree
Showing 2 changed files with 85 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -110,4 +110,25 @@ public <X extends Throwable> R getOrThrow(
}
}

@Override
public boolean equals(Object obj) {
if (obj == this) {
return true;
}
if (obj == null) {
return false;
}
if (!obj.getClass().equals(getClass())) {
return false;
}
SimpleResult<?> that = (SimpleResult<?>) obj;
return Objects.equals(that.value, value)
&& Objects.equals(that.message, message);
}

@Override
public int hashCode() {
return Objects.hash(value, message);
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
/*
* Copyright 2000-2021 Vaadin Ltd.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not
* use this file except in compliance with the License. You may obtain a copy of
* the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations under
* the License.
*/
package com.vaadin.flow.data.binder;

import org.junit.Assert;
import org.junit.Test;

public class SimpleResultTest {

@Test
public void twoEqualSimpleResults_objectsAreEqual() {
SimpleResult<String> one = new SimpleResult<String>("foo", null);
SimpleResult<String> two = new SimpleResult<String>("foo", null);
Assert.assertEquals(one, two);
}

@Test
public void differentValues_objectsAreUnequal() {
SimpleResult<String> one = new SimpleResult<String>("foo", null);
SimpleResult<String> two = new SimpleResult<String>("baz", null);
Assert.assertNotEquals(one, two);
}

@Test
public void differentMessages_objectsAreUnequal() {
SimpleResult<String> one = new SimpleResult<String>(null, "bar");
SimpleResult<String> two = new SimpleResult<String>(null, "baz");
Assert.assertNotEquals(one, two);
}

@Test
public void differentClasses_objectsAreUnequal() {
SimpleResult<String> one = new SimpleResult<String>("foo", null);
SimpleResult<String> two = new SimpleResult<String>("foo", null) {
};
Assert.assertNotEquals(one, two);
}

@Test
public void nullIsNotEqualToObject() {
SimpleResult<String> one = new SimpleResult<String>("foo", null);
Assert.assertNotEquals(one, null);
}

@Test
public void twoEqualSimpleResults_hashCodeIsTheSame() {
SimpleResult<String> one = new SimpleResult<String>("foo", null);
SimpleResult<String> two = new SimpleResult<String>("foo", null);
Assert.assertEquals(one.hashCode(), two.hashCode());
}
}

0 comments on commit e037475

Please sign in to comment.