Skip to content

Commit

Permalink
Stop logging error when updating dev dependencies (#9476)
Browse files Browse the repository at this point in the history
As there is a conflict with the dependencies and prevent adding
the flow-dev-dependencies package to the platform (#9345), this will hide
the unavoidable error that was logged for Vaadin apps.
 
Fixes #9251
  • Loading branch information
pleku committed Nov 26, 2020
1 parent 857e2ef commit 9a4aa71
Showing 1 changed file with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,8 @@ private JsonObject getVersions(InputStream platformVersions)

String genDevDependenciesPath = getDevDependenciesFilePath();
if (genDevDependenciesPath == null) {
packageUpdater.log().error(
// #9345 - locking dev dependencies doesn't work for now
packageUpdater.log().debug(
"Couldn't find dev dependencies file path from proeprties file. "
+ "Dev dependencies won't be locked");
return versionsJson;
Expand All @@ -255,7 +256,8 @@ private JsonObject readGeneratedDevDependencies(String path)
throws IOException {
URL resource = classFinder.getResource(path);
if (resource == null) {
packageUpdater.log().warn("Couldn't find dev dependencies file. "
// #9345 - locking dev dependencies doesn't work for now
packageUpdater.log().debug("Couldn't find dev dependencies file. "
+ "Dev dependencies won't be locked");
return null;
}
Expand Down

0 comments on commit 9a4aa71

Please sign in to comment.