Skip to content

Commit

Permalink
chore: disable DialogShortcutIT flaky tests (#10496)
Browse files Browse the repository at this point in the history
Temporary solution for #10481 #10487 #10491
  • Loading branch information
mshabarov authored and vaadin-bot committed Mar 30, 2021
1 parent a3c6833 commit 8012c43
Showing 1 changed file with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import com.vaadin.testbench.TestBenchElement;
import org.junit.Assert;
import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test;
import org.openqa.selenium.By;
import org.openqa.selenium.WebElement;
Expand Down Expand Up @@ -75,6 +76,7 @@ public void dialogOpenedWithShortcutNoListenOn_sameShortcutListeningOnUi_bothExe
validateLatestShortcutEvent(4, DialogShortcutView.UI_BUTTON);
}

@Ignore("Flaky test, see https://github.com/vaadin/flow/issues/10481")
@Test
public void dialogOpenedWithListenOnShortcut_dialogReopened_oldShortcutStillWorks() {
openReusedDialog();
Expand Down Expand Up @@ -103,6 +105,7 @@ public void dialogOpenedWithListenOnShortcut_dialogReopened_oldShortcutStillWork
validateLatestDialogShortcut(4, REUSABLE_DIALOG_ID);
}

@Ignore("Flaky test, see https://github.com/vaadin/flow/issues/10487")
// vaadin/vaadin-dialog#229
@Test
public void twoDialogsOpenedWithSameShortcutKeyOnListenOn_dialogWithFocusExecuted() {
Expand All @@ -124,6 +127,7 @@ public void twoDialogsOpenedWithSameShortcutKeyOnListenOn_dialogWithFocusExecute
validateLatestShortcutEvent(3, DialogShortcutView.UI_BUTTON);
}

@Ignore("Flaky test, see https://github.com/vaadin/flow/issues/10491")
// #10362
@Test
public void shortcutAddedWithPreventDefault_inputFocused_enteringOtherKeysToInputWorks() {
Expand Down

0 comments on commit 8012c43

Please sign in to comment.