Fix setClassName to work as specified in javadoc (#8842)

Fixes #8840
vaadin · Aug 12, 2020 · 0e94214 · 0e94214
1 parent 80e3194
commit 0e94214
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/flow-server/src/main/java/com/vaadin/flow/component/HasStyle.java b/flow-server/src/main/java/com/vaadin/flow/component/HasStyle.java
@@ -63,7 +63,11 @@ default boolean removeClassName(String className) {
      *            <code>null</code> to remove all class names
      */
     default void setClassName(String className) {
-        getElement().setAttribute("class", className);
+        if(className == null) {
+            getElement().removeAttribute("class");
+        } else {
+            getElement().setAttribute("class", className);
+        }
     }
 
     /**

diff --git a/flow-server/src/test/java/com/vaadin/flow/component/HasStyleTest.java b/flow-server/src/test/java/com/vaadin/flow/component/HasStyleTest.java
@@ -90,6 +90,11 @@ public void setClassName() {
         assertClasses(component);
         component.setClassName("");
         assertClasses(component);
+
+        component.setClassName("removeMe");
+        // setting null to classname should remove class name attribute
+        component.setClassName(null);
+        assertClasses(component);
     }
 
     @Test