This repository has been archived by the owner on Dec 17, 2020. It is now read-only.
Use innerHTML property to set dynamic resource as an image #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reasons EDGE doesn't show svg image created from the server side. So instead of creating a real "object" element it's set as "innerHTML" property for its "fake" parent element. Fixes #184
|
SonarQube analysis reported 2 issues
Watch the comments in this conversation to review them. |
vaadin-tc
reviewed
Mar 9, 2017
| @@ -61,7 +61,8 @@ private void createGenerateImageButton() { | |||
| Button button = new Button("Generate image"); | |||
|
|
|||
| button.addClickListener(event -> { | |||
| image.setAttribute("data", createResource()); | |||
| // image.setAttribute("data", createResource()); | |||
There was a problem hiding this comment.
This block of commented-out lines of code should be removed. 
vaadin-tc
reviewed
Mar 9, 2017
| image.getStyle().set("display", "block"); | ||
| image.setAttribute("data", createResource()); | ||
| image = new Element("div"); | ||
| // image.setAttribute("type", "image/svg+xml"); |
There was a problem hiding this comment.
This block of commented-out lines of code should be removed.
|
Let's fix this on the framework side instead of making the demo more complex. See vaadin/flow#1344 for details. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reasons EDGE doesn't show svg image created from the server
side. So instead of creating a real "object" element it's set as
"innerHTML" property for its "fake" parent element.
Fixes #184
This change is