Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prevent IllegalArgumentException when sortable columns are remov… (#468) (CP: 20.0) #912

Merged
merged 1 commit into from
May 7, 2021
Merged

fix: Prevent IllegalArgumentException when sortable columns are remov… (#468) (CP: 20.0) #912

merged 1 commit into from
May 7, 2021

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

@TatuLund @manolo
@tulioag @vaadin-bot
fix: Prevent IllegalArgumentException with sortable columns (#468)
03e076b 
* fix: Prevent IllegalArgumentException when sortable columns are removed and recreated

Fixes: vaadin/vaadin-grid#1969
Warranty: Fixes exception related to sorting when recreating columns 

Co-authored-by: Manolo Carrasco <[email protected]>
Co-authored-by: Tulio Garcia <[email protected]>
@vaadin-bot
Copy link
Collaborator Author

SonarQube analysis reported 40 issues

  • CRITICAL 4 critical
  • MAJOR 10 major
  • MINOR 23 minor
  • INFO 3 info

Top 10 issues

  1. CRITICAL Grid.java#L2401: Remove usage of generic wildcard type. rule
  2. CRITICAL Grid.java#L3161: Define a constant instead of duplicating this literal "direction" 5 times. rule
  3. CRITICAL RemoveSortableColumnPage.java#L54: Make "people" transient or serializable. rule
  4. CRITICAL RemoveSortableColumnPage.java#L80: Make "headerGenerator" transient or serializable. rule
  5. MAJOR Grid.java#: This file has 1,861 lines, which is greater than 750 authorized. Split it into smaller files. rule
  6. MAJOR Grid.java#L1937: Call "Optional#isPresent()" before accessing the value. rule
  7. MAJOR Grid.java#L1938: Either log or rethrow this exception. rule
  8. MAJOR Grid.java#L1957: Either log or rethrow this exception. rule
  9. MAJOR Grid.java#L2968: Call "Optional#isPresent()" before accessing the value. rule
  10. MAJOR Grid.java#L2978: Call "Optional#isPresent()" before accessing the value. rule

@manolo manolo merged commit 48a8d7a into 20.0 May 7, 2021
@manolo manolo deleted the cherry-pick-468-to-20.0-1620142181874 branch May 7, 2021 07:45
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with platform 20.0.0.beta2. For prerelease versions, it will be included in its final version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manolo manolo manolo approved these changes

Assignees
No one assigned
Labels
prerelease version for platform 20.0.0 Released with Platform 20.0.0.beta2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vaadin-bot @manolo @TatuLund