fix: do not trigger data communicator reset when no filters

[vursen]

The setDropMode and setRowsDraggable methods were updated to call dataCommunicator.reset to ensure drop filters are applied when the drop mode is set dynamically. While this fixed the original issue, it introduced an unintended side effect: an annoying scroll position reset that now happens e.g. when setting the drop mode dynamically on drag start.

Unfortunately, resolving this new issue completely is impossible without introducing new API in DataCommunicator. An API that would allow us to request refreshItem for only items that are in the viewport.

Since not working filters appear to be a more critical issue, it was decided to keep the original change but try to mitigate its impact by preventing the data reset when no filters are set.

Fixes #6662

[sonarcloud]

Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[vursen]

Meanwhile, I created #6713 in which I described a solution that could help resolve this issue completely.

[vaadin-bot]

Hi @vursen and @vursen, when i performed cherry-pick to this commit to 23.5, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 45ff63f
error: could not apply 45ff63f... fix: do not trigger data communicator reset when no filters (#6712)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

[gektron]

Thank you so much for implementing a fix. What would be the release schedule for this? Will it make 24.5?

[vursen]

@gektron Yes, this fix will be included in the upcoming 24.5 release.

[vaadin-bot]

This ticket/PR has been released with Vaadin 24.6.0.alpha1 and is also targeting the upcoming stable 24.6.0 version.