-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dashboard component #6706
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ugur-vaadin
force-pushed
the
feat/dashboard
branch
2 times, most recently
from
October 10, 2024 11:47
28f9821
to
44b0e2b
Compare
ugur-vaadin
changed the base branch from
main
to
chore/bump-wc-versions-to-24-6
October 10, 2024 11:47
ugur-vaadin
requested review from
DiegoCardoso,
sissbruecker,
tomivirkki,
web-padawan and
vursen
October 10, 2024 11:49
ugur-vaadin
force-pushed
the
feat/dashboard
branch
from
October 10, 2024 13:19
59d7ab3
to
a24e021
Compare
...arent/vaadin-dashboard-flow/src/main/java/com/vaadin/flow/component/dashboard/Dashboard.java
Show resolved
Hide resolved
...arent/vaadin-dashboard-flow/src/main/java/com/vaadin/flow/component/dashboard/Dashboard.java
Show resolved
Hide resolved
...arent/vaadin-dashboard-flow/src/main/java/com/vaadin/flow/component/dashboard/Dashboard.java
Show resolved
Hide resolved
...arent/vaadin-dashboard-flow/src/main/java/com/vaadin/flow/component/dashboard/Dashboard.java
Outdated
Show resolved
Hide resolved
...low/src/main/java/com/vaadin/flow/component/dashboard/DashboardItemMoveModeChangedEvent.java
Show resolved
Hide resolved
...ashboard-flow/src/main/java/com/vaadin/flow/component/dashboard/DashboardItemMovedEvent.java
Outdated
Show resolved
Hide resolved
...arent/vaadin-dashboard-flow/src/main/java/com/vaadin/flow/component/dashboard/Dashboard.java
Show resolved
Hide resolved
sissbruecker
approved these changes
Oct 15, 2024
vaadin-dashboard-flow-parent/vaadin-dashboard-flow-integration-tests/pom.xml
Outdated
Show resolved
Hide resolved
...arent/vaadin-dashboard-flow/src/main/java/com/vaadin/flow/component/dashboard/Dashboard.java
Show resolved
Hide resolved
* feat: add dashboard packages * chore: use correct license * refactor: comment out npm package temporarily * refactor: add polymer legacy adapter * chore: remove incorrect npm package * fix: correct the inverted module names * chore: add license to pom * fix: add module to root level pom * chore: run formatter * feat: add packages for testbench and integration tests * fix: update polymer legacy adapter version * chore: remove unused dependency
* feat: add title for widget * chore: run formatter * refactor: use properties instead of attributes * docs: fix the widget title property name
* feat: introduce add and remove widget functionality to dashboard * fix: add missing lines and run formatter * fix: fix compilation error * chore: run formatter * test: remove first and last widgets and use clickelementswithjs * refactor: make remove from parent use removevirtualchild for widgets * refactor: use append and remove with virtual children and remove from parent before add * chore: remove unused code * refactor: merge attach handlers * refactor: do not try to remove virtual child on detach * refactor: use widgets list to update detach listeners * test: add more unit tests for testing node ids on detach * refactor: use dashboard remove when removing widget from parent * test: use clickelementwithjs without locating element * refactor: remove detach listeners * test: add tests for moving widgets between parents * test: add unit tests for moving widgets between components * test: cleanup dashboard widget related unit tests * refactor: use add remove directly instead of using virtual children * refactor: simplify removing all widgets by reusing single remove logic * refactor: override getchildren
* feat: implement max col count feature * feat: add getter for maximum column count * Update vaadin-dashboard-flow-parent/vaadin-dashboard-flow/src/main/java/com/vaadin/flow/component/dashboard/Dashboard.java Co-authored-by: Tomi Virkki <[email protected]> * Update vaadin-dashboard-flow-parent/vaadin-dashboard-flow/src/main/java/com/vaadin/flow/component/dashboard/Dashboard.java Co-authored-by: Tomi Virkki <[email protected]> --------- Co-authored-by: Tomi Virkki <[email protected]>
* feat: add dashboard widget colspan support * test: add getter for colspan to dashboard widget element * test: use computed styles for getting colspan from testbench element * test: add its for getting and updating colspans * test: updated wording for getting colspan from testbench element
* feat: add max min column width support * test: remove its
* feat: add dashboard sections support * feat: use components to set items on the client side (#6610) * refactor: restore patching virtual container to fix its * test: add its that cover more cases updating the client * refactor: make detach handler implement detach listener
* feat: add content related api to dashboard widget * refactor: make set get content separate from slotted elements * test: update testbench content to check for all slots * feat: add content related api to dashboard widget * refactor: make set get content separate from slotted elements * test: update testbench content to check for all slots * chore: run formatter * test: move tests into appropriate classes
* feat: add content related api to dashboard widget * chore: run formatter * test: move tests into appropriate classes * feat: add rowspan support to dashboard widget
* feat: add content related api to dashboard widget * feat: add header support to dashboard widget * test: fix merge problems * test: add missing buttons to test page
* feat: support drag drop for dashboard * chore: run formatter * test: fix unit test assertion * test: update test route names to align with others * test: add its that test the server client communication * refactor: simplify js event workaround * fix: do not remove widgets on detach * refactor: remove item sanitization on drag reorder * refactor: check children of element and remove workaround * refactor: make dashboard not editable by default * test: use selenium for drag drop and add tests for editable
* refactor: throw exception when setting and getting visibility * refactor: always return true when isvisible is called * refactor: make section and widget return true for isvisible
* refactor: return reordered items and parent from event * fix: handle the case where drag reorder returns the same items * chore: remove unused code * chore: rename incorrectly named test method * refactor: update events based on web component event changes * refactor: align event apis with web component * chore: run formatter
* feat: implement i18n support * test: do not check for default values * refactor: update i18n property names * docs: update wording for i18n methods
* test: add tests for keyboard move and resize * fix: only update client items when necessary * refactor: use id in items array instead of nodeid * refactor: reintroduce removed client item updates * refactor: use id instead of nodeid in item state changed events * refactor: remove unnecessary equality check
* feat: add dense layout support to dashboard * test: remove dense layout its * refactor: update dense property name * chore: update setter wordings
* refactor: rename gap to spacing * docs: update spacing api javadocs
Co-authored-by: Sascha Ißbrücker <[email protected]>
…-tests/pom.xml Co-authored-by: Sascha Ißbrücker <[email protected]>
ugur-vaadin
force-pushed
the
feat/dashboard
branch
from
October 15, 2024 07:34
948c36f
to
4013f26
Compare
Quality Gate passedIssues Measures |
ugur-vaadin
removed request for
DiegoCardoso,
tomivirkki,
vursen and
web-padawan
October 15, 2024 12:58
This ticket/PR has been released with Vaadin 24.6.0.alpha1 and is also targeting the upcoming stable 24.6.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR merges the
Dashboard
component feature branchfeat/dashboard
tomain
.Type of change
Feature