chore: add formatter config to repo #6700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
knoobie
reviewed
Oct 8, 2024
| @@ -450,7 +450,7 @@ | |||
| <configuration> | |||
| <java> | |||
| <eclipse> | |||
| <file>https://raw.githubusercontent.com/vaadin/flow/main/eclipse/VaadinJavaConventions.xml</file> | |||
| <file>${maven.multiModuleProjectDirectory}/eclipse/VaadinJavaConventions.xml</file> | |||
There was a problem hiding this comment.
Ensure to also include the .mvn file Artur has added.. it might sound "stupid" but it's really needed.. had to deal with it in the past in multiple occasions
Edit: nvm this repo already has this folder 👍
tomivirkki
approved these changes
Oct 9, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 9, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 9, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 9, 2024
sissbruecker
added a commit
that referenced
this pull request
Oct 9, 2024
Co-authored-by: Sascha Ißbrücker <[email protected]>
sissbruecker
added a commit
that referenced
this pull request
Oct 9, 2024
Co-authored-by: Sascha Ißbrücker <[email protected]>
sissbruecker
added a commit
that referenced
this pull request
Oct 9, 2024
Co-authored-by: Sascha Ißbrücker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we reference the formatter config from the Flow Github project. That has some downsides:
This adds a duplicate of the config to our repo so that we are not affected by changes in the Flow repo. We can try to sync. the configs from time to time.