feat: add logic for Popover auto-adding on setting target #6565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
feat/popover-auto-add
branch
from
8b9b7bd
to
bcb733f
Compare
...flow-parent/vaadin-popover-flow/src/main/java/com/vaadin/flow/component/popover/Popover.java
Show resolved
Hide resolved
web-padawan
force-pushed
the
feat/popover-auto-add
branch
from
bcb733f
to
30982f6
Compare
web-padawan
changed the title
.../vaadin-popover-flow/src/test/java/com/vaadin/flow/component/popover/PopoverAutoAddTest.java
Outdated
Show resolved
Hide resolved
.../vaadin-popover-flow/src/test/java/com/vaadin/flow/component/popover/PopoverAutoAddTest.java
Outdated
Show resolved
Hide resolved
.../vaadin-popover-flow/src/test/java/com/vaadin/flow/component/popover/PopoverAutoAddTest.java
Outdated
Show resolved
Hide resolved
.../vaadin-popover-flow/src/test/java/com/vaadin/flow/component/popover/PopoverAutoAddTest.java
Outdated
Show resolved
Hide resolved
...flow-parent/vaadin-popover-flow/src/main/java/com/vaadin/flow/component/popover/Popover.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Sascha Ißbrücker <[email protected]>
|
sissbruecker
approved these changes
Aug 27, 2024
|
This ticket/PR has been released with Vaadin 24.5.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on DX tests findings, we decided to introduce auto-adding logic as all the participants were confused with
popover.open()not working with no warnings whenPopoveris not manually added to the UI.UPD: the logic has been changed to auto-add when calling
setTarget()instead ofopen()(and also remove the auto-attached Popover if the target is either detached or reset tonull).Type of change