fix: warn and revert to prev index when selecting invalid index #6543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
changed the title
vursen
changed the title
|
I'll backport this fix to V14 manually once it's approved. |
web-padawan
approved these changes
Aug 14, 2024
FrediWa
approved these changes
Aug 15, 2024
|
vaadin-bot
pushed a commit
that referenced
this pull request
Aug 15, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Aug 15, 2024
1 task
vursen
added a commit
that referenced
this pull request
Aug 16, 2024
… (#6546) Co-authored-by: Sergey Vinogradov <[email protected]>
vursen
added a commit
that referenced
this pull request
Aug 16, 2024
… (#6547) Co-authored-by: Sergey Vinogradov <[email protected]>
vursen
added a commit
that referenced
this pull request
Aug 16, 2024
|
This ticket/PR has been released with Vaadin 24.5.0.alpha10 and is also targeting the upcoming stable 24.5.0 version. |
ZheSun88
pushed a commit
that referenced
this pull request
Sep 23, 2024
ZheSun88
pushed a commit
that referenced
this pull request
Sep 23, 2024
… (CP: 23.5) (#6664) * fix: warn and revert to prev index when selecting invalid index (#6543) * replace getTabCount() with old getComponentCount() * add mockito dependency * add mockito-inline dependecy --------- Co-authored-by: Sergey Vinogradov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR changes the Tabs behavior so that, instead of throwing an exception when selecting an invalid index, it now logs a warning and reverts to the previous selected index, which was valid. This is a rare case that can occur when the user manages to click on a tab that is already in the process of removal by the server, which is in turn a result of some previous action.
Fixes #5214
Type of change