feat: make dialogheaderfooter implement hascomponents #6494
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes
DialogHeaderFooter
implementHasComponents
. This introduces the following APIs to bothDialogHeader
andDialogFooter
:add(Collection<Component> components)
add(String text)
remove(Collection<Component> components)
removeAll()
addComponentAtIndex(int index, Component component
addComponentAsFirst(Component component)
NOTE:
This might be breaking if
dialog.getHeader().add(null);
is used anywhere since it is going to be ambiguous after the refactoring. However, this is unlikely in practice since it is not supported and would throw aNullPonterException
anyway.Fixes #5735
Type of change
Checklist