Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve consistency of JavaDoc for i18n methods #6431

Merged
merged 4 commits into from
Jul 11, 2024
Merged

docs: improve consistency of JavaDoc for i18n methods #6431

merged 4 commits into from
Jul 11, 2024

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Jul 11, 2024 •
edited
Loading

Description

The PR improves the JavaDoc of i18n setters and getters to make it more consistent.

Related to #4618

Type of change

  • Docs

@vursen vursen changed the title docs: improve JavaDoc for i18n methods docs: improve i18n methods JavaDoc for consistency Jul 11, 2024
@vursen vursen changed the title docs: improve i18n methods JavaDoc for consistency docs: improve consistency of JavaDoc for i18n methods Jul 11, 2024
@vursen vursen marked this pull request as ready for review July 11, 2024 08:06
@vursen vursen requested a review from web-padawan July 11, 2024 08:06
web-padawan
web-padawan approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We probably could also update JavaDoc for setI18n to replace "the internationalization properties" with "the internationalization object" for consistency.

@vursen
Copy link
Contributor Author

vursen commented Jul 11, 2024

We probably could also update JavaDoc for setI18n to replace "the internationalization properties" with "the internationalization object" for consistency.

Good point, done.

@vursen vursen enabled auto-merge (squash) July 11, 2024 11:01
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@vursen vursen merged commit eb63f4c into main Jul 11, 2024
5 checks passed
@vursen vursen deleted the improve_i18n_javadocs branch July 11, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@web-padawan web-padawan web-padawan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vursen @web-padawan