Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make Popover implement HasAriaLabel, add overlayRole #6425

Merged
merged 2 commits into from
Jul 10, 2024
Merged

feat: make Popover implement HasAriaLabel, add overlayRole #6425

merged 2 commits into from
Jul 10, 2024

Commits on Jul 10, 2024

  1. feat: make Popover implement HasAriaLabel, add overlayRole

    @web-padawan
    web-padawan committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    6125773 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Sascha Ißbrücker <[email protected]>
    @web-padawan @sissbruecker
    web-padawan and sissbruecker committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    9be0cc0 View commit details
    Browse the repository at this point in the history