feat: add methods to configure Popover trigger mode #6420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sissbruecker
reviewed
Jul 9, 2024
...flow-parent/vaadin-popover-flow/src/main/java/com/vaadin/flow/component/popover/Popover.java
Outdated
Show resolved
Hide resolved
...-parent/vaadin-popover-flow/src/test/java/com/vaadin/flow/component/popover/PopoverTest.java
Outdated
Show resolved
Hide resolved
...flow-parent/vaadin-popover-flow/src/main/java/com/vaadin/flow/component/popover/Popover.java
Outdated
Show resolved
Hide resolved
...flow-parent/vaadin-popover-flow/src/main/java/com/vaadin/flow/component/popover/Popover.java
Outdated
Show resolved
Hide resolved
web-padawan
force-pushed
the
feat/popover-trigger
branch
2 times, most recently
from
ed9ee38
to
9a22019
Compare
web-padawan
force-pushed
the
feat/popover-trigger
branch
from
9a22019
to
31d8272
Compare
|
web-padawan
changed the title
sissbruecker
approved these changes
Jul 9, 2024
|
This ticket/PR has been released with Vaadin 24.5.0.alpha5 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the API to set
triggerproperty on the web component and correspondingPopoverTriggerenum.It is possible to use
nullorCollections.emptySet()to only allow opening / closing programmatically.Type of change