fix: do not invalidate when clearing a valid value #5579
Conversation
vursen
force-pushed
the
fix/do-not-validate-on-clear
branch
from
7409383 to
a828ba7
Compare
vursen
changed the title
vursen
changed the title
|
|
||
| // When the value is cleared programmatically, reset hasInputValue | ||
| // so that the following validation doesn't treat this as bad input. | ||
| if (Objects.equals(value, getEmptyValue())) { |
There was a problem hiding this comment.
note: Even though the issue doesn't manifest in DatePicker because its web component handles hasInputValue differently from other components, I've decided that it won't hurt to include the fix in DatePicker as well in case the web component's implementation changes in the future.
vursen
force-pushed
the
fix/do-not-validate-on-clear
branch
from
4375ff3 to
8454b18
Compare
vursen
force-pushed
the
fix/do-not-validate-on-clear
branch
6 times, most recently
from
c2a4548 to
d488f2b
Compare
vursen
force-pushed
the
fix/do-not-validate-on-clear
branch
from
d488f2b to
84d906a
Compare
|
|
||
| // When the value is cleared programmatically, reset hasInputValue | ||
| // so that the following validation doesn't treat this as bad input. | ||
| if (valueEquals(value, getEmptyValue())) { |
There was a problem hiding this comment.
nit: this "intensive calculation" is done twice for the same params :) (all setValue methods)
There was a problem hiding this comment.
Thanks, extracted into a var.
|
SonarCloud Quality Gate failed.
|
|
This ticket/PR has been released with Vaadin 24.3.0.alpha1 and is also targeting the upcoming stable 24.3.0 version. |
Description
The PR prevents field components that support bad input from invalidating when clearing a valid value programmatically.
Depends on
Fixes #5462
Part of #5537
Type of change