Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Backport of HasLabel interface to v14. #3768

Merged
merged 7 commits into from
Sep 28, 2022
Merged

feat: Backport of HasLabel interface to v14. #3768

merged 7 commits into from
Sep 28, 2022

Conversation

rodolforfq
Copy link
Contributor

Description

Based on #2271. Continuation of flow#14280, #3751 and #3754.

Fixes flow#3241.

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@rodolforfq rodolforfq changed the title Backport of HasLabel interface to v14. feat: Backport of HasLabel interface to v14. Sep 22, 2022
sissbruecker
sissbruecker requested changes Sep 26, 2022
View reviewed changes
...-text-editor-flow/src/main/java/com/vaadin/flow/component/richtexteditor/RichTextEditor.java Outdated Show resolved Hide resolved
...n-text-field-flow/src/main/java/com/vaadin/flow/component/textfield/AbstractNumberField.java Outdated Show resolved Hide resolved
...aadin-text-field-flow/src/main/java/com/vaadin/flow/component/textfield/BigDecimalField.java Outdated Show resolved Hide resolved
...ent/vaadin-text-field-flow/src/main/java/com/vaadin/flow/component/textfield/EmailField.java Outdated Show resolved Hide resolved
.../vaadin-text-field-flow/src/main/java/com/vaadin/flow/component/textfield/PasswordField.java Outdated Show resolved Hide resolved
...arent/vaadin-text-field-flow/src/main/java/com/vaadin/flow/component/textfield/TextArea.java Outdated Show resolved Hide resolved
...rent/vaadin-text-field-flow/src/main/java/com/vaadin/flow/component/textfield/TextField.java Outdated Show resolved Hide resolved
...xt-field-flow/src/main/java/com/vaadin/flow/component/textfield/GeneratedVaadinTextArea.java Outdated Show resolved Hide resolved
...t-field-flow/src/main/java/com/vaadin/flow/component/textfield/GeneratedVaadinTextField.java Outdated Show resolved Hide resolved
sissbruecker
sissbruecker approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@sissbruecker sissbruecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@sissbruecker sissbruecker merged commit 9ead614 into vaadin:14.9 Sep 28, 2022
@rodolforfq rodolforfq deleted the 14.9 branch September 28, 2022 12:48
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 14.9.0.alpha1 and is also targeting the upcoming stable 14.9.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sissbruecker sissbruecker sissbruecker approved these changes

Assignees
No one assigned
Labels
prerelease version for Vaadin 14.9.0 Released with Vaadin 14.9.0.alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rodolforfq @vaadin-bot @sissbruecker