fix: force refreshValue to update input value on the client-side

[vursen]

Description

The earlier fix by @sissbruecker doesn't cover the case when ComboBox is cleared in the same round-trip as a custom value is set, e.g when calling comboBox.clear() in a customValueSet listener.

The issue manifests when trying to set a custom value on a combo-box without value. In that case, the internal customValueSet listener does have effect, setting _inputElementValue from an empty value to the custom value. However, since ComboBox is immediately cleared, it comes out like nothing has changed for the server in the end: _inputElementValue remains empty as it was, although it is not empty on the client-side.

This PR changes refreshValue() to force _inputElementValue client-side update by using the executeJs API.

Depends on

• test: reorganize ComboBox ClearValue ITs #3716

Fixes #1090

Type of change

• Bugfix

Checklist

• I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
• I have added a description following the guideline.
• The issue is created in the corresponding repository and I have referenced it.
• I have added tests to ensure my change is effective and works as intended.
• New and existing tests are passing locally with my change.
• I have performed self-review and corrected misspellings.

[vursen]

note: I added this change more for the sake of consistency. It doesn't matter for the fix.

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
36 Code Smells

No Coverage information
0.0% Duplication

[vaadin-bot]

Hi @vursen and @vursen, when i performed cherry-pick to this commit to 23.2, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 0d90f58
error: could not apply 0d90f58... fix: force refreshValue to update input value on the client-side (#3712)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

[vaadin-bot]

Hi @vursen and @vursen, when i performed cherry-pick to this commit to 23.1, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 0d90f58
error: could not apply 0d90f58... fix: force refreshValue to update input value on the client-side (#3712)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

[vaadin-bot]

Hi @vursen and @vursen, when i performed cherry-pick to this commit to 14.8, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 0d90f58
error: could not apply 0d90f58... fix: force refreshValue to update input value on the client-side (#3712)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

[vaadin-bot]

This ticket/PR has been released with Vaadin 23.3.0.alpha1 and is also targeting the upcoming stable 23.3.0 version.