fix: ensure DateTimePicker initializes client side value property #2884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sissbruecker
approved these changes
Mar 17, 2022
...-time-picker-flow/src/main/java/com/vaadin/flow/component/datetimepicker/DateTimePicker.java
Outdated
Show resolved
Hide resolved
vursen
force-pushed
the
fix/date-time-picker/initial-value
branch
from
bc0dccb to
ade6c72
Compare
|
|
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 18, 2022
) * fix: ensure DateTimePicker initializes client side value property * chore: apply code review suggestions * chore: run formatter Co-authored-by: Sascha Ißbrücker <[email protected]>
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 18, 2022
) * fix: ensure DateTimePicker initializes client side value property * chore: apply code review suggestions * chore: run formatter Co-authored-by: Sascha Ißbrücker <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
sissbruecker
added a commit
that referenced
this pull request
Mar 18, 2022
) (#2893) * fix: ensure DateTimePicker initializes client side value property * chore: apply code review suggestions * chore: run formatter Co-authored-by: Sascha Ißbrücker <[email protected]> Co-authored-by: Sergey Vinogradov <[email protected]> Co-authored-by: Sascha Ißbrücker <[email protected]>
sissbruecker
added a commit
that referenced
this pull request
Mar 18, 2022
) (#2894) * fix: ensure DateTimePicker initializes client side value property * chore: apply code review suggestions * chore: run formatter Co-authored-by: Sascha Ißbrücker <[email protected]> Co-authored-by: Sergey Vinogradov <[email protected]> Co-authored-by: Sascha Ißbrücker <[email protected]>
|
This ticket/PR has been released with Vaadin 23.1.0.alpha1 and is also targeting the upcoming stable 23.1.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes DateTimePicker so that it initializes the web component's
valueproperty with an empty string rather than leave it to benullwhen DateTimePicker is being instantiated with no value. This is needed to prevent thevalue-changedevent on the server side which comes from the client side as a result of Polymer convertingnullto"".Part of #2691
Type of change
Checklist