Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add HasStyle interface to AppLayout #2854 #2877

Merged
merged 4 commits into from
Mar 16, 2022

Conversation

krissvaa
Copy link
Contributor

Description

feat: Add HasStyle interface to App layout component

Some Flow components currently didn't implement the HasStyle interface, making it awkward to apply CSS classnames and inline styles to them.

This code change adds this functionality.

Fixes #2853

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

…java/com/vaadin/flow/component/applayout/AppLayoutTest.java
@krissvaa krissvaa linked an issue Mar 16, 2022 that may be closed by this pull request
@krissvaa krissvaa changed the title Add HasStyle interface to AppLayout #2854 feat: Add HasStyle interface to AppLayout #2854 Mar 16, 2022
@krissvaa krissvaa enabled auto-merge (squash) March 16, 2022 09:21
@krissvaa krissvaa merged commit b476342 into master Mar 16, 2022
@krissvaa krissvaa deleted the feat/app-layout-has-styles branch March 16, 2022 09:28
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 839 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 23.1.0.alpha1 and is also targeting the upcoming stable 23.1.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HasStyle interface to AppLayout Add HasStyle interface to Crud
3 participants