Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename private property _theme to __theme #2844

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Mar 11, 2022

Description

The private property _theme that Flow uses internally for storing the menu bar item theme must be renamed to __theme in order to prevent it from possible interference with the web component's property _theme that has recently appeared in vaadin/web-components#3529.

Type of change

  • Internal

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug D 4 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 12 Security Hotspots
Code Smell B 840 Code Smells

No Coverage information No Coverage information
5.0% 5.0% Duplication

@vursen vursen merged commit 5ccf1b1 into master Mar 11, 2022
@vursen vursen deleted the fix/rename-_theme-to-__theme branch March 11, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants