feat: Web Push Options #3889
Merged
feat: Web Push Options #3889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Language unchecked
caalador
requested changes
Nov 8, 2024
Comment on lines
304
to
327
| [source,java] | ||
| ---- | ||
| WebPushAction webPushAction = new WebPushAction("dashboard", "Open Dashboard"); | ||
| WebPushOptions webPushOptions = new WebPushOptions( | ||
| body, | ||
| List.of(webPushAction), | ||
| "This is my data", | ||
| "https://example.com/my-icon.png" | ||
| ); | ||
| webPush.sendNotification(subscription, new WebPushMessage(title, webPushOptions)); | ||
| ---- | ||
|
|
||
| `WebPushAction` and `WebPushOptions` records are not part of the Vaadin Web Push API and must be defined within the project. | ||
|
|
||
| [source,java] | ||
| ---- | ||
| public record WebPushAction(String action, String title) implements Serializable { | ||
| } | ||
| public record WebPushOptions(String body, | ||
| List<WebPushAction> actions, | ||
| Serializable data, | ||
| String icon) implements Serializable { | ||
| } | ||
| ---- |
There was a problem hiding this comment.
I would perhaps have these in the reverse order so that the record definitions are shown first to not create confusion on where these are available.
So say for the following records [sample records] they can be used as [sample creation]....
caalador
approved these changes
Nov 11, 2024
russelljtdyer
added
Language checking
russelljtdyer
added
Language checked
|
Could we still rename the file from |
|
|
|
Thanks. I’ll update it. I assume there shouldn't be too many links to this pages out in the wild, so we won't need any redirect rules for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents vaadin/flow#20285.