fix: revert static drop mode for tree grid #3786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
approved these changes
Oct 9, 2024
|
Meanwhile, I created vaadin/flow-components#6713 in which I described a solution that could resolve this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago, #3444 updated the grid examples to set the drop mode dynamically. However, in tree grids, setting the drop mode dynamically on drag start causes an immediate reset of the scroll position. This completely disrupts the drag-and-drop process unless the grid is at the top. While losing the scroll position is a known limitation in tree grids, we should avoid recommending configurations that result in a reset right at the start of dragging.
Related to vaadin/flow-components#6662