This repository has been archived by the owner on Jul 6, 2021. It is now read-only.
Prepare for lit-element 2.3.0 version bump #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
web-padawan
force-pushed
the
lit-element-bump
branch
2 times, most recently
from
d16d504
to
498bafb
Compare
web-padawan
force-pushed
the
lit-element-bump
branch
from
498bafb
to
54b5829
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to #29
In the 2.3.0 release, there will be a new public API
getStylesthat we can use.At the same time, private API that we are currently using will not be reliable anymore.
In particular, the timings for setting
_styleshave changed.As a result of this change, the following test has to be adjusted:
Before
should inject to subclassed componentsAfter
should not inject to subclassed componentsThis is how it already works in the real components (e.g.
vaadin-accordion-panelthat extendsvaadin-details) that have their ownstyles. So apparently the previous test was broken.Tested this locally based on lit/lit-element#853