refactor: fix unit tests after app-config changes #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds necessary mocking for application configuration for CdiServlet in unit tests. Related to vaadin/flow#9642
denis-anisimov
approved these changes
Dec 23, 2020
| @@ -61,6 +66,14 @@ public void setUp() throws ServletException { | |||
| Mockito.when(servletContext.getAttribute(Lookup.class.getName())) | |||
| .thenReturn(lookup); | |||
|
|
|||
| final DefaultApplicationConfigurationFactory applicationConfigurationFactory | |||
There was a problem hiding this comment.
There is no need to mock DefaultApplicationConfigurationFactory or its interface.
It's enough to properly mock ServletContext:
the ApplicationConfiguration is retrieved from the context by the attribute ApplicationConfiguration.class.getName().
If there is no attribute value then the factory is called. But if the attribute is given right away then it will be just returned without asking the factory.
But this is not really important. It just allows to reduce a number of lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds necessary mocking for application configuration for CdiServlet
in unit tests.
Related to vaadin/flow#9642