Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use WrapperDescriptor and instead use Wrap/Unwrap APIs #187

Merged
merged 1 commit into from
May 29, 2024

Conversation

mlippautz
Copy link

Node has very basic support for wrapping objects and an experimental API to use CppHeap (Oilpan).

This PR switches the API to using v8::Object::Wrap() and v8::Object::Unwrap() instead of using regular embedder fields.

The PR is likely incomplete but enough to get basic tests to compile.

Also, the old apporach did distinguish between managed and unmanaged wrappers. Really, this distinction is gone as the new Wrap/Unrap APIs only support a single (the current) CppHeap.

@victorgomes victorgomes merged commit 0daffdf into v8:node-ci-2024-04-23 May 29, 2024
10 of 15 checks passed
isheludko pushed a commit to isheludko/node that referenced this pull request Jun 3, 2024
victorgomes pushed a commit that referenced this pull request Jun 3, 2024
pthier pushed a commit that referenced this pull request Jul 15, 2024
victorgomes pushed a commit that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants