Skip to content

Commit

Permalink
Migrate to a new V8 interceptors Api (#180)
Browse files Browse the repository at this point in the history
The new callback should return v8::Intercepted::kYes/kNo to indicate
whether the operation was intercepted. This replaces the old approach
where the callback had to leave the return value unset or set it to
an empty handle to indicate that the the request wasn't intercepted.

See https://crrev.com/c/5465509 and https://crrev.com/c/5465513.
# Conflicts:
#	src/node_contextify.cc

# Conflicts:
#	src/node_contextify.cc
#	src/node_env_var.cc
  • Loading branch information
victorgomes committed Nov 18, 2024
1 parent 3d96060 commit ce325c0
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/node_env_var.cc
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,6 @@ static Intercepted EnvSetter(Local<Name> property,
}

env->env_vars()->Set(env->isolate(), key, value_string);

return Intercepted::kYes;
}

Expand Down

0 comments on commit ce325c0

Please sign in to comment.