Skip to content

Commit

Permalink
Merge remote-tracking branch 'upstream/master' into feature/support-b…
Browse files Browse the repository at this point in the history
…uild-retry-docker-if-error-packaging

* upstream/master:
  Fix the url of reviewdog (elastic#21981)
  revert WSS process reporting for windows (elastic#22055)
  Fix typo (elastic#19585) (elastic#22061)
  • Loading branch information
v1v committed Oct 22, 2020
2 parents 109932a + 215f49c commit 5ae1ae8
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 16 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.next.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,7 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d
- Fix azure storage event format. {pull}21845[21845]
- Fix panic in kubernetes autodiscover related to keystores {issue}21843[21843] {pull}21880[21880]
- [Kubernetes] Remove redundant dockersock volume mount {pull}22009[22009]
- Revert change to report `process.memory.rss` as `process.memory.wss` on Windows. {pull}22055[22055]

*Packetbeat*

Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ GOLINT=golint
GOLINT_REPO=golang.org/x/lint/golint
REVIEWDOG=reviewdog
REVIEWDOG_OPTIONS?=-diff "git diff master"
REVIEWDOG_REPO=github.com/haya14busa/reviewdog/cmd/reviewdog
REVIEWDOG_REPO=github.com/reviewdog/reviewdog/cmd/reviewdog
XPACK_SUFFIX=x-pack/

# PROJECTS_XPACK_PKG is a list of Beats that have independent packaging support
Expand Down
2 changes: 1 addition & 1 deletion heartbeat/docs/monitors/monitor-http.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ Under `check.response`, specify these options:

*`status`*:: A list of expected status codes. 4xx and 5xx codes are considered `down` by default. Other codes are considered `up`.
*`headers`*:: The required response headers.
*`body`*:: A list of regular expressions to match the the body output. Only a single expression needs to match. HTTP response
*`body`*:: A list of regular expressions to match the body output. Only a single expression needs to match. HTTP response
bodies of up to 100MiB are supported.

Example configuration:
Expand Down
15 changes: 1 addition & 14 deletions metricbeat/module/system/process/process.go
Original file line number Diff line number Diff line change
Expand Up @@ -150,24 +150,11 @@ func (m *MetricSet) Fetch(r mb.ReporterV2) error {
rootFields.Put("process.args", args)
}

// This is a temporary fix until we make these changes global across libbeat
// This logic should happen in libbeat getProcessEvent()

// There's some more Windows memory quirks we need to deal with.
// "rss" is a linux concept, but "wss" is a direct match on Windows.
// "share" is also unavailable on Windows.
// "share" is unavailable on Windows.
if runtime.GOOS == "windows" {
proc.Delete("memory.share")
}

if m.IsAgent {
if runtime.GOOS == "windows" {
if setSize := getAndRemove(proc, "memory.rss"); setSize != nil {
proc.Put("memory.wss", setSize)
}
}
}

e := mb.Event{
RootFields: rootFields,
MetricSetFields: proc,
Expand Down

0 comments on commit 5ae1ae8

Please sign in to comment.