Skip to content

Commit

Permalink
Ivan's comments applied
Browse files Browse the repository at this point in the history
  • Loading branch information
v-Golubev committed Nov 19, 2024
1 parent 04d179a commit 62e44fe
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/common/snippets/include/snippets/pass/tokenization.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ class SnippetsTokenization : public ov::pass::ModelPass {
bool dyn_mha_token, std::set<size_t> mha_transpose_ranks, ov::pass::param_callback mha_tokenize_mm_b_input_callback = nullptr)
: m_concurrency(concurrency), m_data_ptr_gpr_count(data_ptr_gpr_count), m_split_m_dimension(split_m_dimension),
m_mha_token_enable_transpose_on_output(enable_transpose_on_output), m_is_dynamic_mha_token_enabled(dyn_mha_token),
m_mha_supported_transpose_ranks(std::move(mha_transpose_ranks)), m_mha_tokenize_mm_b_input_callback(mha_tokenize_mm_b_input_callback) {
m_mha_supported_transpose_ranks(std::move(mha_transpose_ranks)), m_mha_tokenize_mm_b_input_callback(std::move(mha_tokenize_mm_b_input_callback)) {
OPENVINO_ASSERT(concurrency > 0, "Concurrency should be greater than 0");
OPENVINO_ASSERT(data_ptr_gpr_count > 0, "data_ptr_gpr_count should be greater than 0");
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ class RuntimeConfigurator {
static UnifiedLoopInfoRtParams get_loop_runtime_params(const lowered::UnifiedLoopInfoPtr& unified_loop_info);
using LoopInfoRuntimeParamsMap = std::unordered_map<lowered::UnifiedLoopInfoPtr, UnifiedLoopInfoRtParams>;
/**
* @brief Update Loop informations in LinearIR: Unified and ExpandedLoopInfo
* @brief Update Loop information in LinearIR: Unified and ExpandedLoopInfo
* @param linear_ir LinearIR
*/
static void update_loop_info(const lowered::LinearIRCPtr& linear_ir);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ size_t compute_inner_n_block(const ov::element::Type& precision) {
}
}

const ov::snippets::lowered::ExpressionPtr get_copy_b_expr(const ov::snippets::lowered::ExpressionPtr& brgemm_expr) {
ov::snippets::lowered::ExpressionPtr get_copy_b_expr(const ov::snippets::lowered::ExpressionPtr& brgemm_expr) {
OPENVINO_ASSERT(ov::is_type<BrgemmCPU>(brgemm_expr->get_node()), "get_copy_b_expr must be called only for BrgemmCPU node");
const auto b_input_expr = brgemm_expr->get_input_port_connector(1)->get_source().get_expr();
if (ov::is_type<BrgemmCopyB>(b_input_expr->get_node())) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,11 @@ T compute_LDB(T n_block, const ov::element::Type& precision) {
std::max(n_block, static_cast<T>(compute_inner_n_block(precision)));
}
/**
* @brief Retrieves the expression pointer for the brgemm_copy_b emitter corresponding to the given BrgemmCPU expression.
* @brief Retrieves the expression pointer for the brgemm_copy_b expression corresponding to the given BrgemmCPU expression.
* @param brgemm_expr The expression pointer for the BrgemmCPU operation.
* @return The expression pointer for the BrgemmCopyB operation.
*/
const snippets::lowered::ExpressionPtr get_copy_b_expr(const snippets::lowered::ExpressionPtr& brgemm_expr);
snippets::lowered::ExpressionPtr get_copy_b_expr(const snippets::lowered::ExpressionPtr& brgemm_expr);
} // namespace repacking
} // namespace brgemm_utils
} // namespace intel_cpu
Expand Down

0 comments on commit 62e44fe

Please sign in to comment.