Figure for Dave B #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoapg
reviewed
Jun 15, 2020
|
|
||
|
|
||
| def validate_against_dispo_data(dispo_data, slot_df, day, month, year, slot_status): | ||
| def validate_against_dispo_data(dispo_data, slot_df, day, month, year, slot_type): |
There was a problem hiding this comment.
Conflict with the namka_plot changes
Comment on lines
+417
to
+420
| if slot_type == 'show': | ||
| slot_types = ['show', 'inpatient'] | ||
| elif slot_type == 'no-show': | ||
| slot_types = ['no-show'] |
There was a problem hiding this comment.
also has conflict with the Namka plot changes
| else: | ||
| print('invalid status') | ||
| return | ||
| selected_dispo_rows = dispo_data[(dispo_data['date'].dt.day == day) | ||
| & (dispo_data['date'].dt.month == month) | ||
| & (dispo_data['date'].dt.year == year) | ||
| & (dispo_data['status'].isin(slot_statuses)) | ||
| & (dispo_data['status'].isin(slot_types)) |
There was a problem hiding this comment.
same issue about slot_types
nicoapg
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is branched off of PR #4 "Distinguish no show types". Review and merge that one before reviewing this one.
Saving charts in altair is currently broken by a dependency issue (altair-viz/altair_saver#13). So, the
dave.pycommand line script doesn't currently work. But I tested all of the code up toaltair_saver.save(), and it works:A screenshot of resulting Figure is in the Paper Draft in Notion.