Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(app): basic proposal filtering #7

Merged
merged 12 commits into from
Nov 9, 2023
Merged

feat(app): basic proposal filtering #7

merged 12 commits into from
Nov 9, 2023

Conversation

mxmlnwbr
Copy link
Collaborator

@mxmlnwbr mxmlnwbr commented Nov 6, 2023

Toggle button that hides open proposals or shows all (including open).

toggle.mov

@mxmlnwbr mxmlnwbr self-assigned this Nov 6, 2023
@rschlaefli rschlaefli changed the title feat(index): button to toggle between all proposals and only open ones feat(app): filtering proposals (ALL, OPEN, OWNED) Nov 7, 2023
@rschlaefli rschlaefli changed the title feat(app): filtering proposals (ALL, OPEN, OWNED) feat(app): basic proposal filtering Nov 7, 2023
@mxmlnwbr
Copy link
Collaborator Author

mxmlnwbr commented Nov 8, 2023

@rschlaefli
please review again - Tell me which filters are necessary (tried some stuff ;))

Screen.Recording.2023-11-08.at.19.52.48.mov

@mxmlnwbr mxmlnwbr marked this pull request as ready for review November 8, 2023 18:54
@mxmlnwbr
Copy link
Collaborator Author

mxmlnwbr commented Nov 9, 2023

@rschlaefli
Junger Mann:
Review? :)

rschlaefli
rschlaefli requested changes Nov 9, 2023
View reviewed changes
src/server/routers/_app.ts Outdated Show resolved Hide resolved
src/types/app.ts Outdated Show resolved Hide resolved
src/components/StudentProposals.tsx Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

mxmlnwbr
mxmlnwbr commented Nov 9, 2023
View reviewed changes
Copy link
Collaborator Author

@mxmlnwbr mxmlnwbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished

src/server/routers/_app.ts Outdated Show resolved Hide resolved
src/types/app.ts Outdated Show resolved Hide resolved
src/components/StudentProposals.tsx Show resolved Hide resolved
src/server/routers/_app.ts Outdated Show resolved Hide resolved
mxmlnwbr

This comment was marked as duplicate.

Sign in to view

@mxmlnwbr mxmlnwbr merged commit 9f61c15 into dev Nov 9, 2023
3 checks passed
@mxmlnwbr mxmlnwbr deleted the filter branch November 9, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschlaefli rschlaefli rschlaefli requested changes

Assignees

@mxmlnwbr mxmlnwbr

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxmlnwbr @rschlaefli