Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(app): store provided feedback in session storage #5

Merged
merged 6 commits into from
Nov 7, 2023

Conversation

mxmlnwbr
Copy link
Collaborator

@mxmlnwbr mxmlnwbr commented Nov 1, 2023

disable button - such that supervisors cannot double or tripple submit the same feedback... only problem --> with my implementation all other submit buttons (other proposals) are also disabled until the site is out & back in focus or reloaded.. other solution from your side? @rschlaefli

@mxmlnwbr mxmlnwbr requested a review from rschlaefli November 1, 2023 10:04
@mxmlnwbr mxmlnwbr self-assigned this Nov 1, 2023
src/components/AcceptProposalForm.tsx Outdated Show resolved Hide resolved
src/components/ProposalStatusForm.tsx Outdated Show resolved Hide resolved
src/components/ProposalStatusForm.tsx Outdated Show resolved Hide resolved
src/components/AcceptProposalForm.tsx Show resolved Hide resolved
@mxmlnwbr
Copy link
Collaborator Author

mxmlnwbr commented Nov 2, 2023

@rschlaefli
Tried to improve with useSessionStorage. Hope it's okay now. Feedback welcome!

@mxmlnwbr mxmlnwbr changed the title onFeedbackSubmit disable button onFeedbackSubmit hide forms Nov 2, 2023
@mxmlnwbr mxmlnwbr changed the base branch from main to dev November 3, 2023 08:23
package-lock.json Outdated Show resolved Hide resolved
@rschlaefli rschlaefli marked this pull request as ready for review November 7, 2023 12:24
Copy link

sonarqubecloud bot commented Nov 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
15.4% 15.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@rschlaefli rschlaefli changed the title onFeedbackSubmit hide forms enhance(app): store provided feedback in session storage Nov 7, 2023
@rschlaefli rschlaefli merged commit 59a034b into dev Nov 7, 2023
2 of 3 checks passed
@rschlaefli rschlaefli deleted the disableButton branch November 7, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants