Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance(app): show supervisor proposals for all Supervisors but only show applications for owner/supervisor #16

Merged
merged 4 commits into from
Dec 5, 2023
Merged

enhance(app): show supervisor proposals for all Supervisors but only show applications for owner/supervisor #16

merged 4 commits into from
Dec 5, 2023

Conversation

mxmlnwbr
Copy link
Collaborator

@mxmlnwbr mxmlnwbr commented Dec 4, 2023 •
edited
Loading

This pull request enhances the application by refining the visibility of proposals and applications within the app. The changes ensure a more streamlined display for different user roles:

  • Supervisor Proposals Visibility: All supervisors can now view proposals within the system.
  • Applications Visibility: Applications are now limited to display only for the initial owner of the proposal (owner or topic supervisor)

@mxmlnwbr mxmlnwbr changed the base branch from main to dev December 4, 2023 10:11
@mxmlnwbr mxmlnwbr self-assigned this Dec 4, 2023
@mxmlnwbr mxmlnwbr marked this pull request as ready for review December 4, 2023 10:34
@mxmlnwbr mxmlnwbr requested a review from rschlaefli December 4, 2023 10:34
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mxmlnwbr mxmlnwbr merged commit 1ea8187 into dev Dec 5, 2023
3 checks passed
@mxmlnwbr mxmlnwbr deleted the applications branch December 5, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschlaefli rschlaefli rschlaefli approved these changes

Assignees

@mxmlnwbr mxmlnwbr

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxmlnwbr @rschlaefli