Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement Proposal Application Acceptance Workflow #12

Merged
merged 20 commits into from
Nov 28, 2023
Merged

feat: implement Proposal Application Acceptance Workflow #12

merged 20 commits into from
Nov 28, 2023

Conversation

mxmlnwbr
Copy link
Collaborator

@mxmlnwbr mxmlnwbr commented Nov 17, 2023 •
edited
Loading

The Proposal Application Acceptance Workflow was added. The accept button is right now placed inside the modal (design-wise not final, but to show that it works).
On accept:
→ state of Open Proposal changes immediately
→ "Refresh page notification" (decided not to useLocalStorage for this case)
→ application gets accepted & all other applications for the same Supervisor Proposal get rejected (see Solution implementation).

@mxmlnwbr mxmlnwbr requested a review from rschlaefli November 17, 2023 08:31
@mxmlnwbr mxmlnwbr self-assigned this Nov 17, 2023
@mxmlnwbr
Copy link
Collaborator Author

@rschlaefli
Could you check that it works on your side as well?
Final button not ready for merge → was not sure where to place & didn't want to spend too much time on that!

@rschlaefli rschlaefli changed the title feat(app): Proposal Application Acceptance Workflow Added feat: implement Proposal Application Acceptance Workflow Nov 23, 2023
@mxmlnwbr mxmlnwbr marked this pull request as ready for review November 28, 2023 09:43
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rschlaefli rschlaefli merged commit 3cae829 into dev Nov 28, 2023
3 checks passed
@rschlaefli rschlaefli deleted the acceptApplication branch November 28, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschlaefli rschlaefli rschlaefli approved these changes

Assignees

@mxmlnwbr mxmlnwbr

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxmlnwbr @rschlaefli