Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance(app): improve display of application details with modal #6

Merged
merged 3 commits into from
Nov 7, 2023
Merged

enhance(app): improve display of application details with modal #6

merged 3 commits into from
Nov 7, 2023

Conversation

mxmlnwbr
Copy link
Collaborator

@mxmlnwbr mxmlnwbr commented Nov 2, 2023 •
edited
Loading

@rschlaefli
Tried to improve a bit on the table (still not full mobile friendly (table & modal in design system not really made for mobile device). Date sorting re-enabled, Please Review!

Desktop:
Screenshot 2023-11-06 at 09 04 58
Screenshot 2023-11-06 at 09 05 30

Mobile:

Screenshot 2023-11-06 at 09 08 58
Screenshot 2023-11-06 at 11 27 49

@mxmlnwbr mxmlnwbr requested a review from rschlaefli November 2, 2023 15:46
@mxmlnwbr mxmlnwbr self-assigned this Nov 2, 2023
@mxmlnwbr mxmlnwbr changed the title enhance(ProposalApplication): table design improved with modal Table design improved with modal Nov 2, 2023
@mxmlnwbr mxmlnwbr changed the base branch from main to dev November 3, 2023 08:23
@mxmlnwbr mxmlnwbr marked this pull request as ready for review November 6, 2023 10:27
rschlaefli
rschlaefli approved these changes Nov 7, 2023
View reviewed changes
src/components/ProposalApplication.tsx Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rschlaefli rschlaefli changed the title Table design improved with modal enhance(app): improve display of application details with modal Nov 7, 2023
@rschlaefli rschlaefli merged commit e897848 into dev Nov 7, 2023
3 checks passed
@rschlaefli rschlaefli deleted the table branch November 7, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschlaefli rschlaefli rschlaefli approved these changes

Assignees

@mxmlnwbr mxmlnwbr

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxmlnwbr @rschlaefli