Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Modal): enable scroll for mobile device #74

Merged
merged 2 commits into from
Nov 6, 2023
Merged

fix(Modal): enable scroll for mobile device #74

merged 2 commits into from
Nov 6, 2023

Conversation

mxmlnwbr
Copy link
Contributor

@mxmlnwbr mxmlnwbr commented Nov 6, 2023

@rschlaefli
Modal fixed. For long content, scroll option was disabled for mobile devices.
Please review!

Screen.Recording.2023-11-06.at.09.49.02.mov

@mxmlnwbr mxmlnwbr requested a review from rschlaefli November 6, 2023 08:50
@mxmlnwbr mxmlnwbr self-assigned this Nov 6, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/index.cjs.production.min.js 79.57 KB (-0.01% 🔽)
dist/index.esm.js 63.26 KB (-0.01% 🔽)

@mxmlnwbr mxmlnwbr mentioned this pull request Nov 6, 2023
Merged
1 task
sjschlapbach
sjschlapbach approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@sjschlapbach sjschlapbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@mxmlnwbr mxmlnwbr marked this pull request as ready for review November 6, 2023 09:58
@mxmlnwbr mxmlnwbr changed the title fix(Modal): enable scroll for mobile device chore(Modal): enable scroll for mobile device Nov 6, 2023
@mxmlnwbr mxmlnwbr changed the title chore(Modal): enable scroll for mobile device fix(Modal): enable scroll for mobile device Nov 6, 2023
@mxmlnwbr mxmlnwbr merged commit e98f5a9 into main Nov 6, 2023
6 of 7 checks passed
@sjschlapbach sjschlapbach deleted the mobileModal branch November 6, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjschlapbach sjschlapbach sjschlapbach approved these changes

@rschlaefli rschlaefli Awaiting requested review from rschlaefli

Assignees

@mxmlnwbr mxmlnwbr

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxmlnwbr @sjschlapbach