-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: add maximum width to tooltips of form components and errors #133
Conversation
WalkthroughWalkthroughThe pull request introduces modifications to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (10)
- packages/design-system/src/ColorPicker.tsx (1 hunks)
- packages/design-system/src/DateChanger.tsx (1 hunks)
- packages/design-system/src/FormLabel.tsx (1 hunks)
- packages/design-system/src/Switch.tsx (1 hunks)
- packages/design-system/src/Workflow.tsx (1 hunks)
- packages/design-system/src/forms/FormikDateField.tsx (1 hunks)
- packages/design-system/src/forms/NumberField.tsx (1 hunks)
- packages/design-system/src/forms/SelectField.tsx (1 hunks)
- packages/design-system/src/forms/TextField.tsx (1 hunks)
- packages/design-system/src/forms/TextareaField.tsx (1 hunks)
Files skipped from review due to trivial changes (7)
- packages/design-system/src/ColorPicker.tsx
- packages/design-system/src/DateChanger.tsx
- packages/design-system/src/Switch.tsx
- packages/design-system/src/forms/FormikDateField.tsx
- packages/design-system/src/forms/NumberField.tsx
- packages/design-system/src/forms/SelectField.tsx
- packages/design-system/src/forms/TextareaField.tsx
Additional comments not posted (3)
packages/design-system/src/FormLabel.tsx (1)
35-38
: LGTM!The change to the
tooltip
class name is approved. Adding a maximum width constraint of30rem
will improve the visual presentation of the tooltip by preventing it from becoming too wide.packages/design-system/src/forms/TextField.tsx (1)
194-198
: LGTM!The change to the
className
prop passed to theTooltip
component is approved. Adding a maximum width constraint of30rem
will improve the visual presentation of the tooltip by preventing it from becoming too wide, thereby enhancing the user experience when displaying error messages.packages/design-system/src/Workflow.tsx (1)
259-259
: LGTM!The change to the
tooltip
class name is approved. Adding a maximum width constraint of30rem
will improve the visual presentation of the tooltip by preventing it from becoming too wide. Thez-20
class ensures that the tooltip appears above other elements, enhancing the user experience.
No description provided.