enhance(Toast): hide dismissible button on toast and show with group hover

[sjschlapbach]

No description provided.

[coderabbitai]

Walkthrough

Walkthrough

The changes involve enhancements to the Dismissible toast component in the design system. Updates include a flexible layout for improved visual arrangement, the introduction of multiple toast instances with different types (success, warning, error), and modifications to class names for better interactivity. The button for dismissing toasts is now contextually hidden until the toast is hovered over, allowing for a cleaner design.

Changes

Files	Change Summary
packages/design-system/src/Toast.stories.tsx	Enhanced the presentation of the Dismissible toast component with a flexible layout and multiple toast instances showcasing different configurations. Added type prop for differentiated styling.
packages/design-system/src/Toast.tsx	Modified class names in RadixToast.Root and Button components for improved styling and interactivity, including group-hover effects and contextual visibility of the dismiss button.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0fd0b9f and c1339be.

Files selected for processing (2)

• packages/design-system/src/Toast.stories.tsx (1 hunks)
• packages/design-system/src/Toast.tsx (2 hunks)

Additional comments not posted (3)

packages/design-system/src/Toast.stories.tsx (1)

Line range hint 114-148: LGTM!

The changes to the Dismissible component are approved:

• The outer <div> has been updated to use a flex display with a vertical gap, improving the visual arrangement of the toast messages.
• Multiple Toast components have been added with different types (success, warning, error) and the dismissible prop, showcasing the various configurations of the Toast component.

The changes are consistent with the AI-generated summary and improve the usability and visual clarity of the Dismissible toast component.

packages/design-system/src/Toast.tsx (2)

Line range hint 127-132: LGTM!

The changes to the RadixToast.Root component's class name are approved:

• The addition of the group class allows for group-hover effects, improving the user experience by providing visual feedback when hovering over the toast notification.
• The conditional border classes based on the type prop enhance the visual distinction between different types of toasts (success, warning, error).

---

139-140: LGTM!

The changes to the Button component's class name are approved:

• The addition of the hidden group-hover:block classes means that the button will now be hidden by default and will only appear when the parent element (the toast) is hovered over.
• This change enhances the interactivity of the toast, making the dismiss button more contextually relevant and less intrusive when the toast is not being interacted with.