Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pillar and formula data on minion id change #1835

Merged
merged 1 commit into from
Feb 6, 2020

Conversation

aaannz
Copy link
Contributor

@aaannz aaannz commented Jan 27, 2020

What does this PR change?

When salt client change its minion id, uyuni correctly recognized this and adapt the database entry. However do nothing else and pillar data together with formula data are not renamed/recreated. This then causes missing pillar information for new minion id.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: bugfix

  • DONE

Test coverage

  • Unit tests TODO

  • Cucumber tests were added

  • DONE

Links

Fixes https://github.com/SUSE/spacewalk/issues/10496
Tracks # add downstream PR, if any

  • DONE

Changelogs

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_lint_checkstyle"
  • Re-run test "java_pgsql_tests"
  • Re-run test "ruby_rubocop"
  • Re-run test "schema_migration_test_oracle"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@aaannz
Copy link
Contributor Author

aaannz commented Feb 3, 2020

@ncounter As the https://github.com/SUSE/spacewalk/issues/10496 is assigned to naica, can you suggest someone to take a look at this? Preferable this week so that it can make it to 4.0.5?

Copy link
Contributor

@admd admd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left some small nitpicks.

@aaannz aaannz force-pushed the pillar_migration_on_minionid_change branch from ce090de to 4967356 Compare February 5, 2020 12:46
@aaannz
Copy link
Contributor Author

aaannz commented Feb 5, 2020

@admd Thanks for taking a look. I updated PR with your feedback.

Copy link
Contributor

@admd admd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. JFYI, Can has also made changes into License file yesterday. https://github.com/uyuni-project/uyuni/pull/1867/files.

@aaannz aaannz force-pushed the pillar_migration_on_minionid_change branch from 4967356 to 465732b Compare February 6, 2020 13:33
@aaannz aaannz merged commit 7a330e1 into master Feb 6, 2020
@aaannz aaannz deleted the pillar_migration_on_minionid_change branch February 6, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants